Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Switch from handleRowClicked to defaultColumn #1590

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat: Switch from handleRowClicked to defaultColumn #1590

merged 2 commits into from
Jan 7, 2025

Conversation

dhaselhan
Copy link
Collaborator

@dhaselhan dhaselhan commented Jan 3, 2025 •
edited
Loading

  • Set linkCell Renderer and link props on default column and remove row click.
  • Update cell renderers to support links if present
  • Apply to lots of tables
  • Move test files to be closer to their components

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Frontend Test Results

  1 files  ±0  121 suites  ±0   42s ⏱️ ±0s
417 tests  - 2  397 ✅  - 2  20 💤 ±0  0 ❌ ±0 
419 runs   - 2  399 ✅  - 2  20 💤 ±0  0 ❌ ±0 

Results for commit 23bb835. ± Comparison against base commit 0218467.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 41s ⏱️ -4s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 23bb835. ± Comparison against base commit 0218467.

♻️ This comment has been updated with latest results.

@dhaselhan dhaselhan force-pushed the feat/daniel-cell-links-1533 branch from 18ec1ec to 9ed3d9c Compare January 3, 2025 00:36
prv-proton
prv-proton requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@prv-proton prv-proton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just for compliance reporting floating filter is not visible.

@dhaselhan dhaselhan force-pushed the feat/daniel-cell-links-1533 branch from a96a64f to 1e3e2a5 Compare January 6, 2025 17:54
@dhaselhan dhaselhan requested a review from prv-proton January 6, 2025 17:55
prv-proton
prv-proton approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@dhaselhan
feat: Switch from handleRowClicked to defaultColumn
406d5d3 
* Set linkCell Renderer and link props on default column and remove row click.
* Update cell renderers to all support links if present
* Apply to lots of tables
* Move test files to be closer to their components
@dhaselhan dhaselhan force-pushed the feat/daniel-cell-links-1533 branch from be370ff to 36791a2 Compare January 7, 2025 18:54
@dhaselhan
Code Review Feedback
23bb835 
* Remove disabling of filters on compliance reports
@dhaselhan dhaselhan force-pushed the feat/daniel-cell-links-1533 branch from 36791a2 to 23bb835 Compare January 7, 2025 19:03
@dhaselhan dhaselhan merged commit 9ec582f into release-0.2.0 Jan 7, 2025
1 check passed
@dhaselhan dhaselhan deleted the feat/daniel-cell-links-1533 branch January 7, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prv-proton prv-proton prv-proton approved these changes

@AlexZorkin AlexZorkin Awaiting requested review from AlexZorkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaselhan @prv-proton